Skip to content

[SECURITY_SOLUTION][ENDPOINT] Trusted App Create API to trim hash value before validating it #79545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[SECURITY_SOLUTION][ENDPOINT] Trusted App Create API to trim hash value before validating it #79545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions x-pack/plugins/security_solution/common/endpoint/schema/trusted_apps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,21 @@ describe('When invoking Trusted Apps Schema', () => {
});
}).toThrow();
});

it('should trim hash value before validation', () => {
expect(() => {
body.validate({
...getCreateTrustedAppItem(),
entries: [
{
...getTrustedAppItemEntryItem(),
field: 'process.hash.*',
value: ` ${VALID_HASH_MD5} \r\n`,
},
],
});
}).not.toThrow();
});
});
});
});
14 changes: 9 additions & 5 deletions x-pack/plugins/security_solution/common/endpoint/schema/trusted_apps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,15 @@ export const PostTrustedAppCreateRequestSchema = {

usedFields.push(field);

if (
field === 'process.hash.*' &&
(!hashLengths.includes(value.length) || hasInvalidCharacters.test(value))
) {
return `Invalid hash value [${value}]`;
if (field === 'process.hash.*') {
const trimmedValue = value.trim();

if (
!hashLengths.includes(trimmedValue.length) ||
hasInvalidCharacters.test(trimmedValue)
) {
return `Invalid hash value [${value}]`;
}
}
}
},
Expand Down