[Canvas] Disable datasource UI when expression contains an expression argument #79369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
review
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
Author
|
@elasticmachine merge upstream |
crob611
approved these changes
Oct 5, 2020
Contributor
crob611
left a comment
crob611
left a comment
There was a problem hiding this comment.
Looks good to me. A few small nits that you can clean up if you agree.
x-pack/plugins/canvas/public/components/datasource/datasource_component.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Oct 5, 2020
… argument (elastic#79369) * Disable datasource UI when expression contains an expression argument * Removing unnecessary type coercion
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Oct 5, 2020
… argument (elastic#79369) * Disable datasource UI when expression contains an expression argument * Removing unnecessary type coercion # Conflicts: # x-pack/plugins/canvas/storybook/webpack.config.js
poffdeluxe
added a commit
that referenced
this pull request
Oct 6, 2020
…ession argument (#79369) (#79526) * [Canvas] Disable datasource UI when expression contains an expression argument (#79369) * Disable datasource UI when expression contains an expression argument * Removing unnecessary type coercion # Conflicts: # x-pack/plugins/canvas/storybook/webpack.config.js * Fix es service mock for datasource component test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #78498
With variables in last release, it became evident that the datasource UIs don't like expressions with args that also contain expressions. So, if you're trying to use variables in an expression like
essql query={string "select * from " {var index_name}}you're going to have an error get thrown when navigating to the datasource UI.For now, I think it'd be smart to just disable the datasource editing UI if there are expressions in the arguments.
Checklist
Delete any items that are not applicable to this PR.
For maintainers