Delay client-side feature usage registration until start #79365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
legrego
approved these changes
Oct 4, 2020
Member
legrego
left a comment
legrego
left a comment
There was a problem hiding this comment.
LGTM, tested locally and this resolves the issue I was seeing on the login selector screen. Thanks for the fix!
rudolf
approved these changes
Oct 5, 2020
Contributor
Author
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Oct 5, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Oct 7, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Oct 7, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
joshdover
added a commit
that referenced
this pull request
Oct 7, 2020
…) (#79857) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
joshdover
added a commit
that referenced
this pull request
Oct 7, 2020
… (#79856) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes works around a race condition in the AnonymousPaths service where not all anonymous paths may be registered until setup completes. Plugin execution order changes can result in exposing this race condition. To fix this entirely, we should remove the
core.http.anonymousPaths.isAnonymousAPI from CoreSetup, but that will be a much larger change.Checklist
For maintainers