[UX] Fixed error rate, made sure all filters are applied #79222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
shahzad31
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
botelastic
bot
added
Team:APM - DEPRECATED
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
reviewed
Oct 5, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Had one comment, functionality seems to work when tested locally.
| totalErrors | ||
| ) : ( | ||
| <EuiToolTip content={totalErrors}> | ||
| <>{numeral(totalErrors).format('0 a')}</> |
Contributor
There was a problem hiding this comment.
Again because of EuiText?
Contributor
There was a problem hiding this comment.
Right of course, my mistake.
Contributor
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
justinkambic
approved these changes
Oct 6, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
LGTM and tested filtering and APM link working as expected.
| totalErrors | ||
| ) : ( | ||
| <EuiToolTip content={totalErrors}> | ||
| <>{numeral(totalErrors).format('0 a')}</> |
Contributor
There was a problem hiding this comment.
Right of course, my mistake.
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Oct 6, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes : #78926
ULR filter query wasn't being applied to JS errors, this makes sure that, also added a link for an error to be viewed in apm error details page.
Added few tests for js errors.
gif for an ant :(