Skip to content

Conversation

@afharo
Copy link
Member

@afharo afharo commented Sep 28, 2020

Summary

  • Add schema definition to the collector reporting.
  • Add support to MappedType: { [key in 'prop1' | 'prop2']: OtherType }

Related to #70180.

For maintainers

@afharo afharo added zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:KibanaTelemetry v7.10.0 labels Sep 28, 2020
Comment on lines -166 to -169
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted because it's duplicated in the file

@afharo afharo force-pushed the usage_collection/schema/reporting branch from 728cf0c to f573a28 Compare September 28, 2020 15:58
@TinaHeiligers
Copy link
Contributor

@afharo I reviewed the code after reviewing #78481 and it looks great thus far. That reporting schema is pretty big!

@afharo afharo force-pushed the usage_collection/schema/reporting branch from f573a28 to 82d5d46 Compare September 29, 2020 14:45
@afharo afharo changed the title [Usage Collection] [schema] reporting [Usage Collection] [schema] reporting + add MappedType support Sep 29, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

distributable file count

id value diff baseline
default 45848 +1 45847

History

  • 💚 Build #77528 succeeded f573a289cac8232a5658fc8da19eacac44a7b62b
  • 💔 Build #77406 failed 728cf0ca026f816e127bb4658ecfda0119069847

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo marked this pull request as ready for review September 29, 2020 16:22
@afharo afharo requested a review from a team as a code owner September 29, 2020 16:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@afharo afharo added the review label Sep 29, 2020
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo merged commit 66866d0 into elastic:master Sep 29, 2020
@afharo afharo deleted the usage_collection/schema/reporting branch September 29, 2020 18:00
@lukeelmers lukeelmers added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes review Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.10.0 v8.0.0 zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants