[Vega] Add vega maps statistics to usage collector #78546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
requested review from
DianaDerevyankina,
VladLasitsa and
sulemanof
alexwizp
added
v7.10.0
v8.0.0
Feature:Vega
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
@alexwizp code is LGTM and it works correctly but we would also like to exclude the vega sample data visualizations from the stats in order to have more accurate results. |
sulemanof
suggested changes
Sep 28, 2020
Contributor
sulemanof
left a comment
sulemanof
left a comment
There was a problem hiding this comment.
Overall LGTM, checked locally and works as expected, left comments.
The only concern is about using the hardcoded list of sample dataset excludedFromStatsVisualizations.
Could you please check if we could get this list from the home plugin contract? It seems it's possible both from setup & start as home.sampleData.getSampleDatasets()
src/plugins/vis_type_vega/server/usage_collector/get_usage_collector.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
sulemanof
approved these changes
Sep 29, 2020
Contributor
sulemanof
left a comment
sulemanof
left a comment
There was a problem hiding this comment.
LGTM, checked out locally, works well
stratoula
reviewed
Sep 29, 2020
|
|
||
| const getDefaultVegaVisualizations = (home: UsageCollectorDependencies['home']) => { | ||
| const titles: string[] = []; | ||
| const sampleDataSets = home?.sampleData.getSampleDatasets() ?? []; |
stratoula
approved these changes
Sep 29, 2020
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM, tested locally 👏
Contributor
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Sep 29, 2020
* telemetry * [Vega] Add vega maps statistics to usage collector Closes: elastic#78269 * add tests * ignore sample data visualizations * fix PR comment * get default vega vis from home plugin * match_phrase doesn't work for full text search Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Sep 29, 2020
* telemetry * [Vega] Add vega maps statistics to usage collector Closes: #78269 * add tests * ignore sample data visualizations * fix PR comment * get default vega vis from home plugin * match_phrase doesn't work for full text search Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #78269
Summary
Create a new collector (vis_type_vega) to the vega plugin
This collector collects the following data:
Screens
Checklist
Delete any items that are not applicable to this PR.
For maintainers