Add more robust error handling to OsCgroupMetricsCollector #78213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
reviewed
Sep 23, 2020
| this.noCgroupPresent = true; | ||
| return {}; | ||
| } else { | ||
| throw err; |
Contributor
There was a problem hiding this comment.
Does it comply with the existing LP logic?
Contributor
Author
There was a problem hiding this comment.
Well, there is no more legacy logic :) But yes, this matches the catch-all exception handler that was at the calling level here: https://github.com/elastic/kibana/blob/7.8/src/legacy/server/status/lib/metrics.js#L131
mshustov
approved these changes
Sep 23, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 24, 2020
…8213) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
joshdover
added a commit
that referenced
this pull request
Sep 24, 2020
) (#78435) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #78191
Ensures that any errors that occur during cgroup metric collection cannot crash Kibana.
Checklist
Delete any items that are not applicable to this PR.
For maintainers