Skip to content

Conversation

@shahzad31
Copy link
Contributor

Summary

Fixes: #77849

Improve ping chart y axis labels, add formatting.

Reduced chart size to 200px

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
uptime 1.6MB +902.0B 1.6MB

page load bundle size

id value diff baseline
uptime 25.2KB +74.0B 25.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as ready for review September 21, 2020 14:10
@shahzad31 shahzad31 requested a review from a team as a code owner September 21, 2020 14:10
@shahzad31 shahzad31 self-assigned this Sep 21, 2020
@shahzad31 shahzad31 added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EDIT: pulled this down and ran locally, seemed to work as designed.

@shahzad31 shahzad31 merged commit d3dd505 into elastic:master Sep 22, 2020
@shahzad31 shahzad31 deleted the improve-ping-chart-axis branch September 22, 2020 09:06
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 22, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
* master: (45 commits)
  [CSM] Use stacked chart for page views (elastic#78042)
  [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091)
  Remove service map beta badge (elastic#78039)
  [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124)
  [Alerting] optimize calculation of unmuted alert instances (elastic#78021)
  call .destroy on ace when react component unmounts (elastic#78132)
  [Ingest Manager] Fix agent action acknowledgement (elastic#78089)
  [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127)
  [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606)
  Bump backport to 5.6.0 (elastic#78097)
  [Actions] adds a Test Connector tab in the Connectors list (elastic#77365)
  [Uptime] Improve ping chart axis (elastic#77992)
  [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363)
  [UiActions] Remove duplicate apply filter action  (elastic#77485)
  [APM] Use transaction metrics for transaction error rate (elastic#78009)
  [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983)
  Edit UI text strings in Integrations and Fleet tabs (elastic#75837)
  [baseline capture] switch to large workers (elastic#78109)
  [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956)
  [Mappings editor] Add support for point field type (elastic#77543)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Uptime] ping chart

4 participants