Skip to content

[COPY] Edits text in Reporting Diagnostics tool #77833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2020
Merged

[COPY] Edits text in Reporting Diagnostics tool #77833

merged 4 commits into from
Sep 29, 2020

Conversation

@gchaps
Copy link
Contributor

@gchaps gchaps commented Sep 17, 2020

Summary

This PR:

  • Edits the copy in the Reporting Diagnostics tool to follow EUI guidelines, in particular, changes button labels to sentence case.
  • Provides minor edits to the Reporting Diagnostics documentation.

@gchaps gchaps added zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 17, 2020
@gchaps gchaps requested a review from joelgriffith September 17, 2020 21:45
@gchaps
Copy link
Contributor Author

gchaps commented Sep 23, 2020

@elasticmachine merge upstream

@gchaps
Copy link
Contributor Author

gchaps commented Sep 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

page load bundle size

id value diff baseline
reporting 164.5KB -112.0B 164.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gchaps gchaps merged commit dffd631 into elastic:master Sep 29, 2020
@gchaps gchaps deleted the copy/report-diagnostics branch September 29, 2020 16:12
@gchaps gchaps mentioned this pull request Sep 29, 2020
Merged
gchaps added a commit to gchaps/kibana that referenced this pull request Sep 29, 2020
@gchaps @elasticmachine
[DOCS] Edits copy in Reporting Diagnostics tool (elastic#77833)
6a15fcc 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Sep 29, 2020
@gchaps @elasticmachine
[DOCS] Edits copy in Reporting Diagnostics tool (#77833) (#78816)
48cc501 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

@joelgriffith joelgriffith Awaiting requested review from joelgriffith

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gchaps @kibanamachine @tsullivan @elasticmachine