Skip to content

Additional tests for security solution endpoint telemetry #77800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2020
Merged

Additional tests for security solution endpoint telemetry #77800

merged 2 commits into from
Sep 21, 2020

Conversation

@achuguy
Copy link
Contributor

@achuguy achuguy commented Sep 17, 2020

Summary

work for https://github.com/elastic/security-team/issues/97

Tests for endpoint telemetry given at /api/stats?extended=true

         {
          total_installed: 0,
          active_within_last_24_hours: 0,
          os: [],
          policies: {
            malware: {
              active: 0,
              inactive: 0,
              failure: 0,
            },
          }

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@achuguy achuguy requested review from a team as code owners September 17, 2020 17:52
@achuguy achuguy added Feature:Telemetry Team:Endpoint Data Visibility Team managing the endpoint resolver labels Sep 17, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 17, 2020

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@achuguy achuguy added v7.9.2 release_note:skip Skip the PR/issue when compiling release notes labels Sep 17, 2020
@stacey-gammon
Copy link

stacey-gammon commented Sep 17, 2020

Endpoint artifact already built for 7.9.2. Should this label be changed to 7.x?

@achuguy achuguy added v7.10.0 and removed v7.9.2 labels Sep 17, 2020
@michaelolo24
Copy link
Contributor

michaelolo24 commented Sep 17, 2020 •
edited
Loading

Looks great, thanks! Do you have data for the failure state for enabling malware? I think that was the only scenario I saw that didn't have coverage

@achuguy
Copy link
Contributor Author

achuguy commented Sep 17, 2020

Not yet on the failure state, that's still on my to do list. I'll ask Dan tomorrow if there's a good way to fail the policy

@achuguy
Copy link
Contributor Author

achuguy commented Sep 18, 2020

Yeah, if it's easy I'll knock it out today though

IgorGuz2000
IgorGuz2000 approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@IgorGuz2000 IgorGuz2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achuguy
Copy link
Contributor Author

achuguy commented Sep 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 21, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@achuguy achuguy merged commit c7d28ed into elastic:master Sep 21, 2020
@achuguy achuguy mentioned this pull request Sep 21, 2020
Merged
achuguy added a commit to achuguy/kibana that referenced this pull request Sep 21, 2020
@achuguy @elasticmachine
Adding endpoint telemetry tests (elastic#77800)
59bda62 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/security_solution_endpoint/apps/endpoint/index.ts
@achuguy achuguy deleted the endpoint_telemetry branch September 21, 2020 19:03
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 23, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 23, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 24, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

achuguy added a commit that referenced this pull request Sep 24, 2020
@achuguy @elasticmachine
Adding endpoint telemetry tests (#77800) (#78041)
c912b55 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/security_solution_endpoint/apps/endpoint/index.ts
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@oatkiller oatkiller Awaiting requested review from oatkiller

+1 more reviewer

@IgorGuz2000 IgorGuz2000 IgorGuz2000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@achuguy @elasticmachine @stacey-gammon @michaelolo24 @kibanamachine @IgorGuz2000