[Enterprise Search] Minor flashAPIMessages update #77570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all http error messages should still be expected to contain a message key, so should be a reliable fallback
cee-chen
added
Feature:Plugins
release_note:skip
JasonStoltz
approved these changes
Sep 16, 2020
scottybollinger
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #77258 - I forgot to export the helper :dead_inside:
I also realized that we should add some kind of fallback for HTTP errors without an
attributes.errorsarray/key (applies to HTTP errors that aren't ours, and some of our returned server errors). Themessageskey works really well for this purpose since it's required by Kibana's response factory.Checklist