Skip to content

[Ingest Pipelines] Add descriptions for ingest processors T-U #77497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2020
Merged

[Ingest Pipelines] Add descriptions for ingest processors T-U #77497

merged 4 commits into from
Sep 16, 2020

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 15, 2020

Summary

Adds descriptions and updates UI strings for the following ingest processors:

  • Trim
  • Uppercase
  • URL decode
  • User agent

Relates to #76710

trim-processor-strings

uppercase-processor-strings

url-decode-processor-strings

user-agent-processor-strings

How to test

  1. Start Kibana with basic license
  2. Go to ingest pipelines plugin in management section
  3. Add a processor for each of the forms listed above (attempt to submit to see which fields are required)
  4. Create the pipeline

Checklist

@jrodewig jrodewig added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels Sep 15, 2020
@jrodewig jrodewig requested a review from a team as a code owner September 15, 2020 14:52
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 15, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth
alisonelizabeth approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally. Thanks for working on this @jrodewig!

lockewritesdocs
lockewritesdocs approved these changes Sep 15, 2020
View reviewed changes
Copy link

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks good. Thanks @jrodewig!

@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 16, 2020

Thanks @alisonelizabeth @lockewritesdocs!

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 16, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestPipelines 765.6KB +1.2KB 764.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jrodewig jrodewig merged commit 37465f5 into elastic:master Sep 16, 2020
@jrodewig jrodewig deleted the es_ui-t-u-processor-ui-strings branch September 16, 2020 17:37
@jrodewig jrodewig mentioned this pull request Sep 16, 2020
Merged
jrodewig added a commit that referenced this pull request Sep 16, 2020
@jrodewig @elasticmachine
[Ingest Pipelines] Add descriptions for ingest processors T-U (#77497) (
375b7ff 
#77650)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jloleysens
Copy link
Contributor

jloleysens commented Sep 18, 2020

Woohoo! Thanks @jrodewig for finishing this up! 🍻 to you and @lockewritesdocs for these contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

+1 more reviewer

@lockewritesdocs lockewritesdocs lockewritesdocs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jrodewig @elasticmachine @kibanamachine @jloleysens @alisonelizabeth @lockewritesdocs