Skip to content

Conversation

@JasonStoltz
Copy link
Member

@JasonStoltz JasonStoltz commented Sep 10, 2020

Summary

This PR ports the Credentials view from the stand-alone App Search into the Kibana App Search Plug-in.

screencapture-localhost-5601-app-enterprise-search-app-search-credentials-2020-09-15-13_49_17

Remaining work

Next PR:

  • Flyout.
  • Should be simple, almost all logic is backported and tested
  • Will need roles to be available in AppLogic

Changes

  • Converted from STUI table to EUI table
  • (More to come)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@JasonStoltz JasonStoltz force-pushed the JasonStoltz/credentials-view branch from a16036c to f7af8da Compare September 10, 2020 19:21
@JasonStoltz JasonStoltz force-pushed the JasonStoltz/credentials-view branch from f6c9ad6 to 394effc Compare September 14, 2020 18:51
@JasonStoltz JasonStoltz changed the title Jason stoltz/credentials view [Enterprise Search] Added Credentials Page Sep 15, 2020
@JasonStoltz JasonStoltz force-pushed the JasonStoltz/credentials-view branch from 394effc to a09a8d3 Compare September 15, 2020 19:32
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 15, 2020

💔 Build Failed

Failed CI Steps

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
enterpriseSearch 283 +13 270

async chunks size

id value diff baseline
enterpriseSearch 453.3KB +23.6KB 429.7KB

History

  • 💔 Build #74262 failed 394effc036d7c8d8dff8536596058b6878bc33f2
  • 💔 Build #73874 failed f6c9ad6a4551c12c8933116593c6d0db3a32945c
  • 💔 Build #73842 failed f7af8da5cf1a117278d547f0446c35af51531820

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@daveyholler
Copy link
Contributor

This looks plenty good to me 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants