Skip to content

Conversation

@efreeti
Copy link
Contributor

@efreeti efreeti commented Sep 9, 2020

Backports the following commits to 7.x:

* First version of the trusted apps list.

* Added proper visualisation of OS and Date Created columns.

* Small change in naming in middleware.

* Renamed function to avoid naming confusion.

* Migrated to usage of selectors and memo in list component.

* Added explicit return types.

* Changed to use server schema for service parameter.

* Removed some over generalisation in types.

* Renamed types and properties related to trusted apps page state.

* Renamed types and properties related to trusted apps page state.

* Renamed the action type to be namespaced to trusted apps.

* Merged the exports and declarations in reducer and used constants for defaults.

* Memoization of pagination data structure.

* Used a shared constant for REST API path.

* Improvements and consistency on pagination across tabs.

* Added a bit more typing and used Partial<>

* Made constants readonly and added some useMemo usages.

* Fixed extracting page index from URI.

* Fixed the case of infinite refreshes when there is loading failure (need to rethink a bit conditions when to refresh).

* Resetting state to initial when we navigate away from trusted apps list.

* Fixed mapping page index to the table pagination.

* Changed to using AppAction in reducer.

* Made ServerApiError a default error type for data binding.

* Renamed all types related to data binding to resource state.

* Created index file for state types.

* Fixed parameter extracting code to meet expectations of endpoints list behavior.

* Updated snapshot.

* Changed middleware to only use selectors.

* Added tests for routing.

* Added documentation to the types in async resource state module.

* Added tests for async resource state module.

* Added tests for store selectors.

* Added tests for reducer.

* Moved around imports.

* Added tests for the middleware.

* Added list component tests.

* Removed a redundant function.

* Commiting snapshots.
@efreeti efreeti added the backport This PR is a backport of another PR label Sep 9, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1972 +10 1962

async chunks size

id value diff baseline
securitySolution 10.0MB +29.2KB 9.9MB

page load bundle size

id value diff baseline
securitySolution 816.6KB +2.9KB 813.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efreeti efreeti merged commit c1fd827 into elastic:7.x Sep 10, 2020
@efreeti efreeti deleted the backport/7.x/pr-76304 branch September 10, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants