Rename useRequest's sendRequest return function to resendRequest and remove return value

[cjcenizal]

Per #72947 (comment), this change requires consumers of useRequest to depend on the hook's return values instead of the values resolved by the sendRequest function. It also renames this function to resendRequest to disambiguate it with the standalone sendRequest module.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[sebelga]

Thanks for putting this together @cjcenizal

I would have preferred to simply have a new handler in the lib for that without the need of making any other changes. Would that be possible?

const resendRequest = useCallback(async () => {
  await sendRequest();
}, [sendRequest]);

I like the sendRequest internal naming as it is as it makes things simpler.

EDIT: actually, as you removed the return statement, it could just be

return {
  isInitialRequest,
  isLoading,
  error,
  data,
  resendRequest: sendRequest, // Gives the user the ability to manually request data
};

[jen-huang]

I like the renaming, Ingest Manager changes LGTM

[cjcenizal]

@sebelga Can we keep it as-is? I changed the name for a couple reasons which I think are an improvement:

• To disambiguate it from the sendRequest module. Many apps consume both sendRequest and useRequest and it can become confusing to reason about which one is in use, especially when doing a wide grep. 😄
• To clarify that it's about optionally sending subsequent requests beyond the initial one, which will always be sent.

[sebelga]

@elasticmachine merge upstream

[sebelga]

Changes LGTM! Thanks for making these changes 👍

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4df969c

Build metrics

async chunks size

id	value	diff	baseline
indexLifecycleManagement	185.4KB	+32.0B	185.3KB
indexManagement	1.5MB	+14.0B	1.5MB
ingestManager	1.1MB	+38.0B	1.1MB
ingestPipelines	738.5KB	+10.0B	738.4KB
snapshotRestore	763.3KB	+18.0B	763.3KB
watcher	602.5KB	+2.0B	602.5KB
total		+114.0B

page load bundle size

id	value	diff	baseline
esUiShared	995.0KB	-131.0B	995.2KB

History

• 💚 Build #73276 succeeded a56ee1f
• 💔 Build #72678 failed 4ba67e5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream