Skip to content

URI encode the index names we fetch in the fetchIndices lib function #76584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2020
Merged

URI encode the index names we fetch in the fetchIndices lib function #76584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8fdb8a
URI encode the index names we fetch in the fetchIndices lib function.
cjcenizal Sep 2, 2020
be89276
Merge branch 'master' into bug/uri-encode-reload-indices
elasticmachine Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion x-pack/plugins/index_management/server/lib/fetch_indices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ async function fetchIndicesCall(
// This call retrieves alias and settings (incl. hidden status) information about indices
const indices: GetIndicesResponse = await callAsCurrentUser('transport.request', {
method: 'GET',
path: `/${indexNamesString}`,
// transport.request doesn't do any URI encoding, unlike other JS client APIs. This enables
// working with Logstash indices with names like %{[@metadata][beat]}-%{[@metadata][version]}.
path: `/${encodeURIComponent(indexNamesString)}`,
query: {
expand_wildcards: 'hidden,all',
},
Expand Down