[SECURITY_SOLUTION][ENDPOINT] Fix created_by for Trusted Apps Create api to reflect current logged in user

[paul-tavares]

Summary

Fixed Trusted Apps API implementation so that the it uses the ExceptionListClient scope to the API request handler context, which reflects the current user doing the API call.

With this in place, the EndpointAppContextService was adjusted and the prior changes that stored the ExceptionListClient from the .start() phase was removed (no longer used)

To Test

• Login to kibana with a different user that has superuser role
• issue create api against the Trusted Apps API:

await _core.http.post('/api/endpoint/trusted_apps', {
  body: JSON.stringify({
    name: 'new exception by user paul',
    os: 'windows',
    entries: [{ field: 'path', operator: 'included', type: 'match', value: 'one/two' }],
  }),
});

• Retrieve the list of Trusted Apps items and note the value for created_by:

await _core.http.get('/api/endpoint/trusted_apps', { query: { page: 1 }})

{
  'data': [
    {
      'entries': [{ 'field': 'path', 'operator': 'included', 'type': 'match', 'value': 'one/two' }],
      'description': '',
      'created_at': '2020-09-02T18:51:45.797Z',
      'created_by': 'paul',
      'name': 'new exception by user paul',
      'os': 'windows',
      'id': '597efa60-ed4d-11ea-bad0-f3148524f4b0',
    }
  ], 'total': 1, 'page': 1, 'per_page': 20,
};

[elasticmachine]

Pinging @elastic/endpoint-management (Team:Endpoint Management)

[elasticmachine]

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

[paul-tavares]

@madirey , @FrankHassanabad ,
I would like to define this lists type here by referencing a Type in Lists plugin. You currently have this type defined in server/types.ts:

kibana/x-pack/plugins/lists/server/types.ts

Lines 43 to 46 in fe1c508

	export type ContextProviderReturn = Promise<{
	getListClient: () => ListClient;
	getExceptionListClient: () => ExceptionListClient;
	}>;

Would you be ok if I break out the object that this Promise<> wraps into a separate interface so that I can reference it? so it would be something like:

export interface ListsRequestHandlerContext {
  getListClient: () => ListClient;
  getExceptionListClient: () => ExceptionListClient;
}

export type ContextProviderReturn = Promise<ListsRequestHandlerContext>;

[madirey]

That's fine with me, but I'd get @FrankHassanabad or @yctercero to sign off...

[paul-tavares]

Thanks for the feedback @madirey :)

If @FrankHassanabad does get some time to comment here 😬 , I have also been wondering the following:
I see that the context provided by Kibana server to each route handler some how "knows" about the lists namespace in it although the RequestHandler<> generic type does not have a way to set it. Is it because of this definition in the server/types:

kibana/x-pack/plugins/lists/server/types.ts

Lines 47 to 54 in fe1c508

	declare module 'src/core/server' {
	interface RequestHandlerContext {
	lists?: {
	getExceptionListClient: () => ExceptionListClient;
	getListClient: () => ListClient;
	};
	}
	}

[kevinlog]

👍 from me, but would like @madirey or @FrankHassanabad to also take a look

[pzl]

lgtm

[paul-tavares]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 6f5545a

Build metrics

✅ unchanged

History

• 💚 Build #72249 succeeded ccce3bd
• 💚 Build #72022 succeeded 6845d79

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream