[APM] @ts-error -> @ts-expect-error #76492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
added
release_note:skip
sorenlouv
commented
Sep 2, 2020
| import { Stacktrace } from '.'; | ||
| import { Stackframe } from '../../../../typings/es_schemas/raw/fields/stackframe'; | ||
|
|
||
| // @ts-ignore Styled Components has trouble inferring the types of the default props here. |
Member
Author
There was a problem hiding this comment.
Apparently not anymore :D
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2020
…rok/new-patterns-component-use-array * 'master' of github.com:elastic/kibana: (75 commits) Remove legacy ui-apps-mixin (elastic#76604) remove unused test_utils (elastic#76528) [ML] Functional tests - add UI permission tests (elastic#76368) [APM] @ts-error -> @ts-expect-error (elastic#76492) [APM] Avoid negative offset for error marker on timeline (elastic#76638) [Reporting] rename interfaces to align with task manager integration (elastic#76716) Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220) Test reverting "Add plugin status API (elastic#75819)" (elastic#76707) [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595) [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399) [DOCS] Dashboard-first docs refresh (elastic#76194) Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344) [DOCS] Identifies cloud settings in reporting (elastic#76691) [Security Solution] Refactor timeline details to use search strategy (elastic#75591) es-archiver: Drop invalid index settings, support --query flag (elastic#76522) [DOCS] Identifies graph settings available on cloud (elastic#76661) Add more info about a11y tests (elastic#76045) [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943) [release notes] automatically retry on Github API 5xx errors (elastic#76447) [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392) ...
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Sep 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv
added a commit
that referenced
this pull request
Sep 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple of unnecessary
@ts-ignoredeclarations and decided to replace them all with@ts-expect-errorwhich uncovered a bunch more that could be removed.The advantage of
@ts-expect-erroris that we'll be forced to remove them as they are no longer relevant. We could also start taking advantage of them in tests.Example: is used
@ts-expect-errorin a test where I wanted to ensure that a property was both undefined from a type perspective and from a runtime value perspective:https://github.com/sqren/backport/blob/acdbebda269bfb472ffc69f4650c036765a694f6/src/options/cliArgs.test.ts#L92-L93