[Ingest Manager] Use EPR's Image.path if available #76434

jfsiii · 2020-09-01T20:09:53Z

Summary

Update code to reflect changes to EPR's Image / our RegistryImage. Use .path if both are present or fall back to .src if that's the only property available

closes #76380

I'm not sure if there are other places to check / update. I found these by setting src: never then running the compiler to see the errors. I also did search for src.

Please run locally and / or let me know of any other locations/cases I should check.

jfsiii · 2020-09-01T22:20:22Z

cc @neptunian for 👀 & awareness

ph · 2020-09-02T17:46:29Z

@ruflin fyi

elasticmachine · 2020-09-03T11:30:56Z

Pinging @elastic/ingest-management (Team:Ingest Management)

ruflin

Tested this locally and works as expected.

I must confess at first I was searching for the screenshot change but it seems url={toImage(image.path || image.src)} is all this is needed!

jfsiii · 2020-09-03T21:35:47Z

@elasticmachine merge upstream

jfsiii · 2020-09-05T19:24:31Z

@elasticmachine merge upstream

jfsiii · 2020-09-07T13:20:12Z

@elasticmachine merge upstream

jfsiii · 2020-09-08T20:44:20Z

ping @paul-tavares & @kevinlog

jfsiii · 2020-09-09T16:45:07Z

@elasticmachine merge upstream

jonathan-buttner

Endpoint changes look good 👍

kibanamachine · 2020-09-09T18:41:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9bfc040

Build metrics

async chunks size

id	value	diff	baseline
ingestManager	1.1MB	+12.0B	1.1MB

page load bundle size

id	value	diff	baseline
ingestManager	468.4KB	-52.0B	468.4KB

History

💚 Build #72943 succeeded 3258cca
💚 Build #72801 succeeded 028e9bb
💚 Build #72460 succeeded 95a8d53
💛 Build #71699 was flaky c23bece

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (25 commits) [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931) clean up test (elastic#76887) [Enterprise Search] Update shared API request handler (elastic#77112) [Maps] convert ESAggSource to TS (elastic#76999) Add plugin status API - take 2 (elastic#76732) Adds lens as a readable saved object for read-only dashboard users (elastic#77067) Skip checking for the reserved realm (elastic#76687) Reporting/diagnostics (elastic#74314) Reporting/Test: unskip non-screenshot tests (elastic#77088) Move metrics to setup and add cgroup metrics (elastic#76730) [Enterprise Search] Add Overview landing page/plugin (elastic#76734) First pass. Change TS type. Update OpenAPI (elastic#76434) [CI] Balance xpack ci groups a bit (elastic#77068) [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531) [Maps] convert MetricsEditor to TS (elastic#76727) IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018) [Enterprise Search] Update config data endpoint to v2 (elastic#76970) [ML] Add decision path charts to exploration results table (elastic#73561) Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016) [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981) ...

* master: (41 commits) [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931) clean up test (elastic#76887) [Enterprise Search] Update shared API request handler (elastic#77112) [Maps] convert ESAggSource to TS (elastic#76999) Add plugin status API - take 2 (elastic#76732) Adds lens as a readable saved object for read-only dashboard users (elastic#77067) Skip checking for the reserved realm (elastic#76687) Reporting/diagnostics (elastic#74314) Reporting/Test: unskip non-screenshot tests (elastic#77088) Move metrics to setup and add cgroup metrics (elastic#76730) [Enterprise Search] Add Overview landing page/plugin (elastic#76734) First pass. Change TS type. Update OpenAPI (elastic#76434) [CI] Balance xpack ci groups a bit (elastic#77068) [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531) [Maps] convert MetricsEditor to TS (elastic#76727) IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018) [Enterprise Search] Update config data endpoint to v2 (elastic#76970) [ML] Add decision path charts to exploration results table (elastic#73561) Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016) [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981) ...

…rok/new-patterns-component-use-array * 'master' of github.com:elastic/kibana: (39 commits) [APM] Always load esarchives from common (elastic#77139) [Ingest Manager] Handle Legacy ES client errors (elastic#76865) [Docs] URL Drilldown (elastic#76529) [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931) clean up test (elastic#76887) [Enterprise Search] Update shared API request handler (elastic#77112) [Maps] convert ESAggSource to TS (elastic#76999) Add plugin status API - take 2 (elastic#76732) Adds lens as a readable saved object for read-only dashboard users (elastic#77067) Skip checking for the reserved realm (elastic#76687) Reporting/diagnostics (elastic#74314) Reporting/Test: unskip non-screenshot tests (elastic#77088) Move metrics to setup and add cgroup metrics (elastic#76730) [Enterprise Search] Add Overview landing page/plugin (elastic#76734) First pass. Change TS type. Update OpenAPI (elastic#76434) [CI] Balance xpack ci groups a bit (elastic#77068) [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531) [Maps] convert MetricsEditor to TS (elastic#76727) IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018) [Enterprise Search] Update config data endpoint to v2 (elastic#76970) ... # Conflicts: # src/plugins/es_ui_shared/static/forms/hook_form_lib/components/use_array.ts

* master: (38 commits) Reporting/Test: unskip non-screenshot tests (elastic#77088) Move metrics to setup and add cgroup metrics (elastic#76730) [Enterprise Search] Add Overview landing page/plugin (elastic#76734) First pass. Change TS type. Update OpenAPI (elastic#76434) [CI] Balance xpack ci groups a bit (elastic#77068) [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531) [Maps] convert MetricsEditor to TS (elastic#76727) IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018) [Enterprise Search] Update config data endpoint to v2 (elastic#76970) [ML] Add decision path charts to exploration results table (elastic#73561) Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016) [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981) [Metrics UI] Replace Snapshot API with Metrics API (elastic#76253) legacy utils cleanup (elastic#76608) [ML] Account for "properties" layer in find_file_structure mappings (elastic#77035) fixed typo Upgrade to Kea 2.2 (elastic#77047) a11y tests on spaces home page including feature control (elastic#76515) [ML] Transforms list: persist pagination through refresh interval (elastic#76786) [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876) ...

First pass. Change TS type. Update OpenAPI

c23bece

jfsiii changed the title ~~[Ingest ManagerChange TS type. Update OpenAPI~~ [Ingest Manager] Use EPR's Image.path if available Sep 1, 2020

jfsiii self-assigned this Sep 2, 2020

jfsiii added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 2, 2020

jfsiii marked this pull request as ready for review September 3, 2020 11:30

jfsiii requested a review from a team as a code owner September 3, 2020 11:30

jfsiii requested a review from a team September 3, 2020 11:30

jfsiii requested a review from a team as a code owner September 3, 2020 11:30

ph requested a review from neptunian September 3, 2020 12:47

ruflin mentioned this pull request Sep 3, 2020

Rename image src to path and have src as the original value from the … elastic/package-registry#629

Merged

ruflin added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 3, 2020

ruflin approved these changes Sep 3, 2020

View reviewed changes

Merge branch 'master' into 76380-use-epr-image-path

95a8d53

ruflin approved these changes Sep 4, 2020

View reviewed changes

Merge branch 'master' into 76380-use-epr-image-path

028e9bb

Merge branch 'master' into 76380-use-epr-image-path

3258cca

neptunian approved these changes Sep 8, 2020

View reviewed changes

Merge branch 'master' into 76380-use-epr-image-path

9bfc040

jonathan-buttner approved these changes Sep 9, 2020

View reviewed changes

kevinlog approved these changes Sep 9, 2020

View reviewed changes

jfsiii merged commit 87ca6ff into elastic:master Sep 9, 2020

jfsiii mentioned this pull request Sep 9, 2020

[7.x] [Ingest Manager] Use EPR's Image.path if available (#76434) #77104

Merged

jfsiii pushed a commit that referenced this pull request Sep 9, 2020

[7.x] [Ingest Manager] Use EPR's Image.path if available (#76434)

2b765b1

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

ruflin mentioned this pull request Sep 17, 2020

[Ingest Manager] Remove legacy code for path/src and tar.gz packages #77728

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Ingest Manager] Use EPR's Image.path if available #76434

[Ingest Manager] Use EPR's Image.path if available #76434

Uh oh!

jfsiii commented Sep 1, 2020 •

edited

Loading

Uh oh!

jfsiii commented Sep 1, 2020

Uh oh!

ph commented Sep 2, 2020

Uh oh!

elasticmachine commented Sep 3, 2020

Uh oh!

ruflin left a comment

Uh oh!

jfsiii commented Sep 3, 2020

Uh oh!

jfsiii commented Sep 5, 2020

Uh oh!

jfsiii commented Sep 7, 2020

Uh oh!

jfsiii commented Sep 8, 2020 •

edited

Loading

Uh oh!

jfsiii commented Sep 9, 2020

Uh oh!

jonathan-buttner left a comment

Uh oh!

kibanamachine commented Sep 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[Ingest Manager] Use EPR's Image.path if available #76434

[Ingest Manager] Use EPR's Image.path if available #76434

Uh oh!

Conversation

jfsiii commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

jfsiii commented Sep 1, 2020

Uh oh!

ph commented Sep 2, 2020

Uh oh!

elasticmachine commented Sep 3, 2020

Uh oh!

ruflin left a comment

Choose a reason for hiding this comment

Uh oh!

jfsiii commented Sep 3, 2020

Uh oh!

jfsiii commented Sep 5, 2020

Uh oh!

jfsiii commented Sep 7, 2020

Uh oh!

jfsiii commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfsiii commented Sep 9, 2020

Uh oh!

jonathan-buttner left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 9, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jfsiii commented Sep 1, 2020 •

edited

Loading

jfsiii commented Sep 8, 2020 •

edited

Loading