[ILM] Fix json in request flyout #75971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
release_note:fix
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
added
release_note:skip
Contributor
Author
|
Hi @jloleysens , thanks again for spotting the bug! would you mind looking at this PR? |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Aug 27, 2020
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Did not test locally - happy with the addition of the test.
Great work @yuliacech !
...fecycle_management/public/application/sections/edit_policy/components/policy_json_flyout.tsx
Show resolved
Hide resolved
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #75952 (a regression bug introduced in #75148). The issue with json in flyout request was fixed by using a serialized policy instead of a un-serialized object from UI. Also a jest test was added to prevent such regression in the future.