[Maps] add message to empty add tooltip card #75809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
Aug 25, 2020
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
thanks! I expect in-app docs like this will really help with discoverability of features 🤞
x-pack/plugins/maps/public/components/tooltip_selector/tooltip_selector.tsx
Outdated
Show resolved
Hide resolved
gchaps
reviewed
Aug 25, 2020
Contributor
gchaps
left a comment
gchaps
left a comment
There was a problem hiding this comment.
Maybe you don't need a title?
To create filters from field values, add a tooltip field.
Add field
Contributor
Author
|
Chatted offline with @gchaps and going to keep text as suggested by @thomasneirynck. Title is required so users know what the setting card refers too. |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 25, 2020
* [Maps] add message to empty add tooltip card * use suggested text
nreese
added a commit
that referenced
this pull request
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some empty state text to Tooltip field selector to highlight the functionallity enabled by adding tooltip fields. This was a recommendation from #75598 (review)