[Telemetry] schema check throw on missing schema #75750
Conversation
Bamieh
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
| if (root.esMappingDiffs.length && throwOnDiff) { | ||
| throw Error( | ||
| `The following changes must be persisted in ${fullPath} file. Use '--fix' to update.\n${JSON.stringify( | ||
| differences, | ||
| null, | ||
| 2 | ||
| )}` | ||
| ); | ||
| } |
There was a problem hiding this comment.
I've got the same question as in #75747 (comment): Are devs in charge of running these changes themselves (maintaining the merged-schemas JSON files) and we simply accept them? Or are we supposed to run the extract after FF to see all the changes at once?
There was a problem hiding this comment.
Devs run the --fix to update the json files, and we approve them since we are the owners of that file. After FF we run the extract to grab json file to see all the additions between releases similiar to what we do with i18n.
There was a problem hiding this comment.
Does extract generate another JSON file? I thought it was the same one. But it that's the intended process. LGTM 👍
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
lukeelmers
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
5 participants
Update schemas and add a check to throw when schemas change.