[Security Solution] Optimizes the index queries to not block the NodeJS event loop

[FrankHassanabad]

Summary

Before this PR you can see event loop block times of:

formatIndexFields: 7986.884ms

After this PR you will see event loop block times of:

formatIndexFields: 85.012ms

within the file:

x-pack/plugins/security_solution/server/lib/index_fields/elasticsearch_adapter.ts

For the GraphQL query of SourceQuery/IndexFields

This also fixes the issue of unknown being returned to the front end by removing code that is no longer functioning as it was intended. Ensure during testing of this PR that blank/default and non exist indexes within securitySolution:defaultIndex still work as expected.

Before, notice the unknown instead of the filebeat-*:

After:

An explanation of how to see the block times for before and after

For perf testing you first add timed testing to the file:

x-pack/plugins/security_solution/server/lib/index_fields/elasticsearch_adapter.ts

Before this PR, around lines 42:

console.time('formatIndexFields'); // <--- start timer
const fields = formatIndexFields(
  responsesIndexFields,
  Object.keys(indexesAliasIndices) as IndexAlias[]
);
console.timeEnd('formatIndexFields'); // <--- outputs the end timer
return fields;

After this PR, around lines 42:

console.time('formatIndexFields'); // <--- start timer
const fields = await formatIndexFields(responsesIndexFields, indices);
console.timeEnd('formatIndexFields');  // <--- outputs the end timer
return fields;

And then reload the security solutions application web page here:

http://localhost:5601/app/security/timelines/default

Be sure to load it twice for testing as NodeJS will sometimes report better numbers the second time as it does optimizations after the first time it encounters some code paths.

You will begin to see numbers similar to this before this PR:

formatIndexFields: 2553.279ms

This indicates that it is blocking the event loop for ~2.5 seconds befofe this fix. If you add additional indexes to your securitySolution:defaultIndex indexes that have additional fields then this amount will increase exponentially. For developers using our test servers I created two other indexes called delme-1 and delme-2 with additional mappings you can add like below

apm-*-transaction*, auditbeat-*, endgame-*, filebeat-*, logs-*, packetbeat-*, winlogbeat-*, delme-1, delme-2

Then you are going to see times approaching 8 seconds of blocking the event loop like so:

formatIndexFields: 7986.884ms

After this fix on the first pass unoptimized it will report

formatIndexFields: 373.082ms

Then after it optimizes the code paths on a second page load it will report

formatIndexFields: 84.304ms

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/siem (Team:SIEM)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2cfa109

Build metrics

✅ unchanged

History

• 💚 Build #70098 succeeded 6709047
• 💚 Build #69874 succeeded 0f1e090
• 💚 Build #69856 succeeded 6ea2a45

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[spong]

LGTM! Appreciate the test coverage and detailed comments to ensure the HOT CODE PATH's are easily identified so other developers know the implications of changes to this part of the code base. Many thanks for all the work here @FrankHassanabad!

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)