Skip to content

Conversation

@pheyos
Copy link
Member

@pheyos pheyos commented Aug 20, 2020

Summary

This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.

Details

There have been conflicting merges of #75307 and #75061.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Aug 20, 2020
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 77a434b into elastic:master Aug 20, 2020
@pheyos pheyos deleted the fix_api_imports branch August 20, 2020 10:38
pheyos added a commit to pheyos/kibana that referenced this pull request Aug 20, 2020
This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.

(cherry picked from commit 77a434b)
@pheyos
Copy link
Member Author

pheyos commented Aug 20, 2020

The 7.x backport is done as part of #75529

pheyos added a commit that referenced this pull request Aug 20, 2020
…test files (#75307) (#75529)

* [ML] Functional tests - refactor structure of ML and Transform test files (#75307)

This PR refactors the structure of ML and Transform functional UI test files.

* [ML] Functional tests - fix imports in results API tests (#75533)

This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants