[expressions] Remove legacy APIs. #75517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
release_note:plugin_api_changes
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lukeelmers
force-pushed
the
fix/expressions-remove-legacy
branch
from
980bb21 to
24fe22f
Compare
lukeelmers
commented
Aug 20, 2020
Member
Author
There was a problem hiding this comment.
I noticed this is the only remaining usage of createKibanaUtilsCore in the repo, so I've removed that in this PR as well.
Considering that it isn't used elsewhere and is also based on createGetterSetter which we've been moving away from, I thought it was safe to remove... but please let me know if there's any reason you feel we need to keep it.
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load bundle size
History
To update your PR or re-run it, just comment with: |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Aug 20, 2020
lukeelmers
added a commit
that referenced
this pull request
Aug 20, 2020
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46906
Summary
Now that Canvas has removed their dependencies on the legacy Expressions APIs, we are able to remove the unused code from both the client & server, and officially consider the expressions server API "complete".
Changes
__LEGACYAPIs from client & serverpublic/services.tsby removing unneeded getter/settersbfetchdependency as it is no longer neededbfetchkibana_utilshelpercreateKibanaUtilsCore, which is now no longer being used in the repoTesting
This PR is simply removing dead code, and therefore introduces no functional changes. Should there be any issues, they would most likely surface in Canvas and be quite obvious.
Dev Docs
The
expressionsplugin has officially removed its__LEGACYAPIs beginning in7.10, which were designed for internal use in Canvas. In the unlikely event you are relying on anything in theexpressions.__LEGACYnamespace, you will need to copy the relevant code into your plugin before updating.Also removed in this change was the
createKibanaUtilsCorehelper from thekibana_utilsplugin, which was only used in the legacy Expressions APIs.