[Data Telemetry] Rename dataset.* to data_stream.* #75415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Feature:Telemetry
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
Member
Author
|
@elasticmachine merge upstream |
afharo
commented
Aug 21, 2020
| export interface DataTelemetryDocument extends DataTelemetryBasePayload { | ||
| dataset?: { | ||
| name?: string; | ||
| type?: DataTelemetryType | 'unknown' | string; // The union of types is to help autocompletion with some known `dataset.type`s |
Member
Author
There was a problem hiding this comment.
'unknown' was there from the initial implementation. But now, if unknown, we simply don't report it 🙂
Member
Author
|
@elasticmachine merge upstream |
1 similar comment
Member
Author
|
@elasticmachine merge upstream |
Bamieh
approved these changes
Aug 24, 2020
Member
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Aug 24, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
afharo
added a commit
that referenced
this pull request
Aug 24, 2020
lukeelmers
added
the
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes needed to be able to read the
datasetandtypeinformation from the newdata_streamfields in the mappings.Resolves #74240
Checklist
Delete any items that are not applicable to this PR.
For maintainers