Skip to content

[Discover] Fixed issue with query bar not taking full width in safari when selected #74987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2020
Merged

[Discover] Fixed issue with query bar not taking full width in safari when selected #74987

merged 2 commits into from
Aug 17, 2020

Conversation

@shamin
Copy link
Contributor

@shamin shamin commented Aug 13, 2020 •
edited
Loading

Summary

Fixed issue with query bar not taking full width in safari when selected. Fixes #72832
Bug: https://stackoverflow.com/questions/19452034/css-width-0-and-overflow-hidden-issue-in-safari

Before
image

After
image

Checklist

For maintainers

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 13, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 13, 2020 •
edited
Loading

💚 CLA has been signed

@mbondyra mbondyra changed the title Fixed issue with query bar not taking full width in safari when selected [Discover] Fixed issue with query bar not taking full width in safari when selected Aug 13, 2020
@mbondyra
Copy link
Contributor

mbondyra commented Aug 13, 2020

Jenkins, test this.

@mbondyra
Copy link
Contributor

mbondyra commented Aug 13, 2020

Thanks a lot @shamin - tested both on Safari and FF and it is in fact fixed! I will merge it once CI is green :)

@timroes timroes added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Aug 14, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 14, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the v7.9.1 label Aug 14, 2020
@flash1293
Copy link
Contributor

flash1293 commented Aug 14, 2020

@elastic/kibana-design I think this requires an approval from your side as well. Our codeowner file had some problems, that's why you didn't get pinged automatically.

@timroes timroes requested a review from a team August 14, 2020 07:45
snide
snide approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for the fix.

@shamin
Copy link
Contributor Author

shamin commented Aug 16, 2020

@elasticmachine merge upstream

1 similar comment
@kertal
Copy link
Member

kertal commented Aug 17, 2020

@elasticmachine merge upstream

@timroes
Copy link
Contributor

timroes commented Aug 17, 2020

Jenkins, test this (seems CI got stuck on it)

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 17, 2020

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
data 1.4MB +252.0B 1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes merged commit 9295378 into elastic:master Aug 17, 2020
@timroes timroes mentioned this pull request Aug 17, 2020
Merged
timroes pushed a commit to timroes/kibana that referenced this pull request Aug 17, 2020
@shamin @elasticmachine @timroes
Fixed issue with query bar not taking full width in safari (elastic#7…
2ac8445 
…4987)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@timroes timroes mentioned this pull request Aug 17, 2020
Merged
timroes pushed a commit to timroes/kibana that referenced this pull request Aug 17, 2020
@shamin @elasticmachine @timroes
Fixed issue with query bar not taking full width in safari (elastic#7…
98562a2 
…4987)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@shamin shamin deleted the safari-width-fix branch August 17, 2020 15:40
timroes pushed a commit that referenced this pull request Aug 18, 2020
@shamin @elasticmachine
Fixed issue with query bar not taking full width in safari (#74987) (#…
c74c842 
…75170)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Shamin Meerankutty <8272719+shamin@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
timroes pushed a commit that referenced this pull request Aug 18, 2020
@shamin @elasticmachine
Fixed issue with query bar not taking full width in safari (#74987) (#…
724e2c2 
…75169)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Shamin Meerankutty <8272719+shamin@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@timroes
Copy link
Contributor

timroes commented Aug 18, 2020

Thanks for opening that PR and your first contribution to Kibana 🎉 I've merged and backported this, so it will be released in the next upcoming minor release (7.10.0) and the next patch release for 7.9. I hope you stay with us in the Kibana community and I hope to see you soon in another PR or issue again 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbondyra mbondyra mbondyra approved these changes

+1 more reviewer

@snide snide snide approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

💝community Feature:Discover Discover Application release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.9.1 v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Discover] query bar doesn't stretch to the whole width when selected on Safari

8 participants

@shamin @kibanamachine @mbondyra @elasticmachine @flash1293 @kertal @timroes @snide