Skip to content

[i18n] revert reverted changes #74633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 10, 2020
Merged

[i18n] revert reverted changes #74633

merged 3 commits into from
Aug 10, 2020

Conversation

@Bamieh
Copy link
Member

@Bamieh Bamieh commented Aug 10, 2020 •
edited
Loading

Reapply #70423 to master. Changes already applied to 7.x and 7.8.

@Bamieh Bamieh added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Aug 10, 2020
@Bamieh Bamieh requested a review from mistic August 10, 2020 08:17
@Bamieh Bamieh requested a review from a team as a code owner August 10, 2020 08:17
@Bamieh Bamieh added the v8.0.0 label Aug 10, 2020
@Bamieh
Copy link
Member Author

Bamieh commented Aug 10, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member

mistic commented Aug 10, 2020

@elasticmachine merge upstream

mistic
mistic approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 10, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 23adb25 into elastic:master Aug 10, 2020
@Bamieh Bamieh deleted the i18n/new_checker_master branch August 10, 2020 13:29
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 11, 2020
@gmmorris
Merge branch 'master' into task-manager/prevent-reschedule-of-running…
87c2879 
…-task

* master: (42 commits)
  Allow any hostname for chromium proxy bypass (elastic#74693)
  [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533)
  [Metrics UI] Fix No Data preview pluralization (elastic#74399)
  [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688)
  Remove karma tests  from legacy maps (elastic#74668)
  [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683)
  [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392)
  [visualizations] Add i18n translation for 'No results found' (elastic#74619)
  [maps] convert vector style properties to TS (elastic#74553)
  bump geckodriver binary to 0.27 (elastic#74638)
  fix: update apm agents to catch abort requests (elastic#74658)
  [Security Solution] Resolver children pagination (elastic#74603)
  add memoryStatus to df analytics page and analytics table in management (elastic#74570)
  [Ingest Manager] Allow prerelease in package version (elastic#74452)
  [App Arch]: remove legacy karma tests (elastic#74599)
  [i18n] revert reverted changes (elastic#74633)
  [Lens] Clear out all attribute properties before updating (elastic#74483)
  [Uptime] Fix full reloads while navigating to alert/ml (elastic#73796)
  Index pattern field class refactor (elastic#73180)
  [ML] Functional tests - stabilize DFA job type check (elastic#74631)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bamieh @mistic @kibanamachine @elasticmachine