Add README files for Kibana app plugins #74277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
reviewed
Aug 5, 2020
kertal
reviewed
Aug 5, 2020
kertal
approved these changes
Aug 5, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Contains the code review: LGTM!
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 5, 2020
* Add README files for Kibana app plugins * Update src/plugins/timelion/README.md Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * Update src/plugins/vis_type_vislib/README.md Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> # Conflicts: # .github/CODEOWNERS
Merged
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 5, 2020
* Add README files for Kibana app plugins * Update src/plugins/timelion/README.md Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * Update src/plugins/vis_type_vislib/README.md Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> # Conflicts: # .github/CODEOWNERS
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 5, 2020
* master: update docs (elastic#74364) [Ingest Node Pipelines] Refactor pipeline simulator code (elastic#72328) Add README files for Kibana app plugins (elastic#74277) [APM] Average for transaction error rate includes null values (elastic#74345) [Ingest Manager] Adjust dataset aggs to use datastream fields instead (elastic#74342)
timroes
pushed a commit
that referenced
this pull request
Aug 5, 2020
…74364) (#74368) * Add README files for Kibana app plugins (#74277) * Add README files for Kibana app plugins * Update src/plugins/timelion/README.md Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * Update src/plugins/vis_type_vislib/README.md Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> # Conflicts: # .github/CODEOWNERS * update docs (#74364) * Remove CODEOWNERS Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Readme files for all Kibana App plugins to appear on https://www.elastic.co/guide/en/kibana/master/code-exploration.html.
Also removed one no longer existing folder from the CODEOWNERS file (I thought otherwise noone wants to ever setup a separate PR for that one line :D)