-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Solution][Exceptions] - Fixes builder overflow and updates ux for nested entries #74262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/setup/metricbeat_migration·js.Monitoring app Setup mode metricbeat migration setup mode btn should existStandard OutStack TraceBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/siem (Team:SIEM) |
dplumlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small nit would be that MyOverflowContainer and MyValuesInput don't really follow the naming convention we have in the rest of these files but everything else looks fine
I'll be the first to admit that I get 0 creative points for naming things. :) I'll follow up on this as there's still more cleanup to do in subsequent PRs. Thanks @dplumlee ! |
…ux for nested entries (elastic#74262) ## Summary - updates the builder nested entries so that the children do not display the parent path - so instead of `parent.child` it just shows `child` - updates the builder to fix overflow issue
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
parent.childit just showschildOverflow issue
Overflow fix
Example of nested ux
Checklist