Skip to content

[SIEM] Adds pin event to timeline cypress test #74256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2020
Merged

[SIEM] Adds pin event to timeline cypress test #74256

merged 5 commits into from
Aug 12, 2020

Conversation

@MadameSheema
Copy link
Contributor

@MadameSheema MadameSheema commented Aug 4, 2020

Summary

In this PR we are adding a cypress test in order to check that an event can be correctly pinned to the timeline.

In order to do that:

  1. We click on the pin icon
  2. We check that the API request made is correct
  3. We check that the pin icon is in the correct state

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Aug 4, 2020
@MadameSheema MadameSheema requested review from a team as code owners August 4, 2020 14:22
@MadameSheema MadameSheema self-assigned this Aug 4, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 4, 2020

Pinging @elastic/siem (Team:SIEM)

@MadameSheema
Copy link
Contributor Author

MadameSheema commented Aug 10, 2020

@elasticmachine merge upstream

@MadameSheema
Copy link
Contributor Author

MadameSheema commented Aug 10, 2020

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor

stephmilovic commented Aug 12, 2020

@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the new test @MadameSheema. Ran it locally and passed with no issues. LGTM!

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 12, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 64b609b into elastic:master Aug 12, 2020
@MadameSheema MadameSheema deleted the adds-pin-event branch August 12, 2020 15:09
@MadameSheema MadameSheema mentioned this pull request Aug 12, 2020
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 12, 2020
@MadameSheema @elasticmachine
[SIEM] Adds pin event to timeline cypress test (elastic#74256)
88b8c4e 
* adds 'pin event' cypress test

* refactors code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 12, 2020
@MadameSheema @elasticmachine
[SIEM] Adds pin event to timeline cypress test (elastic#74256)
226440d 
* adds 'pin event' cypress test

* refactors code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@MadameSheema MadameSheema mentioned this pull request Aug 12, 2020
Merged
MadameSheema added a commit that referenced this pull request Aug 13, 2020
@MadameSheema @elasticmachine
[SIEM] Adds pin event to timeline cypress test (#74256) (#74863)
e36cb63 
* adds 'pin event' cypress test

* refactors code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MadameSheema added a commit that referenced this pull request Aug 13, 2020
@MadameSheema @elasticmachine
[SIEM] Adds pin event to timeline cypress test (#74256) (#74862)
f28d967 
* adds 'pin event' cypress test

* refactors code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@XavierM XavierM Awaiting requested review from XavierM

@angorayc angorayc Awaiting requested review from angorayc

Assignees

@MadameSheema MadameSheema

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MadameSheema @elasticmachine @stephmilovic @kibanamachine @MindyRS