Skip to content

[7.x] Closes #73998 by using canAccessML in the ML capabilities API to (#73999) #74021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2020
Merged

[7.x] Closes #73998 by using canAccessML in the ML capabilities API to (#73999) #74021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a354a
Closes #73998 by using `canAccessML` in the ML capabilities API to (#…
ogupte Jul 31, 2020
fb460ae
Merge branch '7.x' into backport/7.x/pr-73999
elasticmachine Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/apm/public/components/app/Home/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ interface Props {

export function Home({ tab }: Props) {
const { config, core } = useApmPluginContext();
const isMLEnabled = !!core.application.capabilities.ml;
const canAccessML = !!core.application.capabilities.ml?.canAccessML;
const homeTabs = getHomeTabs(config);
const selectedTab = homeTabs.find(
(homeTab) => homeTab.name === tab
Expand All @@ -106,7 +106,7 @@ export function Home({ tab }: Props) {
</EuiButtonEmpty>
</SettingsLink>
</EuiFlexItem>
{isMLEnabled && (
{canAccessML && (
<EuiFlexItem grow={false}>
<AnomalyDetectionSetupLink />
</EuiFlexItem>
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/apm/public/components/app/Settings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { useApmPluginContext } from '../../../hooks/useApmPluginContext';

export function Settings(props: { children: ReactNode }) {
const plugin = useApmPluginContext();
const isMLEnabled = !!plugin.core.application.capabilities.ml;
const canAccessML = !!plugin.core.application.capabilities.ml?.canAccessML;
const { search, pathname } = useLocation();
return (
<>
Expand Down Expand Up @@ -51,7 +51,7 @@ export function Settings(props: { children: ReactNode }) {
'/settings/agent-configuration'
),
},
...(isMLEnabled
...(canAccessML
? [
{
name: i18n.translate(
Expand Down