Skip to content

[7.x][ML] Removes link from helper text on ML overview page #73965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2020
Merged

[7.x][ML] Removes link from helper text on ML overview page #73965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5be7ee
[7.x][ML] Removes link from helper text on ML overview page.
szabosteve Jul 31, 2020
c8c1546
Merge branch '7.x' into 7.x.ml.fix.helper
elasticmachine Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions x-pack/plugins/ml/public/application/overview/components/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,12 @@ import { EuiFlexItem, EuiLink, EuiSpacer, EuiText, EuiTitle } from '@elastic/eui
import { FormattedMessage } from '@kbn/i18n/react';
import { useMlKibana } from '../../contexts/kibana';

const createJobLink = '#/jobs/new_job/step/index_or_search';
const feedbackLink = 'https://www.elastic.co/community/';

interface Props {
createAnomalyDetectionJobDisabled: boolean;
}

function getCreateJobLink(createAnomalyDetectionJobDisabled: boolean) {
return createAnomalyDetectionJobDisabled === true ? (
<FormattedMessage
id="xpack.ml.overview.gettingStartedSectionCreateJob"
defaultMessage="creating a new job"
/>
) : (
<EuiLink href={createJobLink} target="blank">
<FormattedMessage
id="xpack.ml.overview.gettingStartedSectionCreateJob"
defaultMessage="creating a new job"
/>
</EuiLink>
);
}

export const OverviewSideBar: FC<Props> = ({ createAnomalyDetectionJobDisabled }) => {
const {
services: {
Expand Down Expand Up @@ -59,7 +42,7 @@ export const OverviewSideBar: FC<Props> = ({ createAnomalyDetectionJobDisabled }
<p>
<FormattedMessage
id="xpack.ml.overview.gettingStartedSectionText"
defaultMessage="Welcome to Machine Learning. Get started by reviewing our {docs} or {createJob}. We recommend using {transforms} to create feature indices for analytics jobs."
defaultMessage="Welcome to Machine Learning. Get started by reviewing our {docs} or creating a new job. We recommend using {transforms} to create feature indices for analytics jobs."
values={{
docs: (
<EuiLink href={docsLink} target="blank">
Expand All @@ -69,7 +52,6 @@ export const OverviewSideBar: FC<Props> = ({ createAnomalyDetectionJobDisabled }
/>
</EuiLink>
),
createJob: getCreateJobLink(createAnomalyDetectionJobDisabled),
transforms: (
<EuiLink href={transformsLink} target="blank">
<FormattedMessage
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12376,9 +12376,7 @@
"xpack.ml.overview.feedbackSectionLink": "オンラインでのフィードバック",
"xpack.ml.overview.feedbackSectionText": "ご利用に際し、ご意見やご提案がありましたら、{feedbackLink}までお送りください。",
"xpack.ml.overview.feedbackSectionTitle": "フィードバック",
"xpack.ml.overview.gettingStartedSectionCreateJob": "新規ジョブを作成中",
"xpack.ml.overview.gettingStartedSectionDocs": "ドキュメンテーション",
"xpack.ml.overview.gettingStartedSectionText": "機械学習へようこそ。はじめに{docs}や{createJob}をご参照ください。{transforms}を使用して、分析ジョブの機能インデックスを作成することをお勧めします。",
"xpack.ml.overview.gettingStartedSectionTitle": "はじめて使う",
"xpack.ml.overview.gettingStartedSectionTransforms": "Elasticsearchの変換",
"xpack.ml.overview.overviewLabel": "概要",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12379,9 +12379,7 @@
"xpack.ml.overview.feedbackSectionLink": "在线反馈",
"xpack.ml.overview.feedbackSectionText": "如果您在体验方面有任何意见或建议，请提交{feedbackLink}。",
"xpack.ml.overview.feedbackSectionTitle": "反馈",
"xpack.ml.overview.gettingStartedSectionCreateJob": "创建新作业",
"xpack.ml.overview.gettingStartedSectionDocs": "文档",
"xpack.ml.overview.gettingStartedSectionText": "欢迎使用 Machine Learning。首先阅读我们的{docs}或{createJob}。建议使用 {transforms} 为分析作业创建功能索引。",
"xpack.ml.overview.gettingStartedSectionTitle": "入门",
"xpack.ml.overview.gettingStartedSectionTransforms": "Elasticsearch 的转换",
"xpack.ml.overview.overviewLabel": "概览",
Expand Down