Skip to content

Conversation

@yctercero
Copy link
Contributor

Backports the following commits to 7.x:

…ort (elastic#73865)

## Summary

Addresses feedback from elastic#72748

- Updates `plugins/lists` tests text from `should not validate` to `should FAIL validation` after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
- Remove unnecessary spreads from one of my late night PRs
- Removes `siem_common_deps` in favor of `shared_imports` in `plugins/lists`
- Updates `build_exceptions_query.test.ts` to use existing mocks
@yctercero yctercero added the backport This PR is a backport of another PR label Jul 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
lists 122 -1 123

page load bundle size

id value diff baseline
lists 269.5KB -489.0B 270.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit f257c88 into elastic:7.x Jul 31, 2020
@yctercero yctercero deleted the backport/7.x/pr-73865 branch October 14, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants