[Canvas][tech-debt] Add Typescript to apps directory #73766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
clintandrewhall
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
crob611
approved these changes
Aug 3, 2020
Contributor
crob611
left a comment
crob611
left a comment
There was a problem hiding this comment.
Looks good. See one minor question in the ExportApp
x-pack/plugins/canvas/public/apps/export/export/export_app.component.tsx
Outdated
Show resolved
Hide resolved
clintandrewhall
commented
Aug 6, 2020
x-pack/plugins/canvas/public/apps/export/export/export_app.component.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/canvas/public/apps/workpad/workpad_app/workpad_app.component.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
clintandrewhall
added a commit
that referenced
this pull request
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
/appsdirectory contains components that, combined with therouter, load various views of Canvas. This PR strongly-types these components and related files.It also removes a few "loading" components that were impossible to render, (e.g.
nullworkpad in state) and weren't even i18n'd.Anything involving the router was left for future work involved in typing or replacing it.
Testing