-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Alerting] removes ESO migration from alerting #73420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gmmorris
merged 1 commit into
elastic:master
from
gmmorris:alerting/unplug-alerting-from-eso-migrations
Jul 28, 2020
Merged
[Alerting] removes ESO migration from alerting #73420
gmmorris
merged 1 commit into
elastic:master
from
gmmorris:alerting/unplug-alerting-from-eso-migrations
Jul 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
bmcconaghy
approved these changes
Jul 28, 2020
Contributor
bmcconaghy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10. This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
This was referenced Jul 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10. This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions. # Conflicts: # x-pack/plugins/alerts/server/saved_objects/migrations.test.ts # x-pack/plugins/alerts/server/saved_objects/migrations.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/migrations.ts
gmmorris
added a commit
that referenced
this pull request
Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10. This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
gmmorris
added a commit
that referenced
this pull request
Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10. This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
Merged
1 task
This was referenced Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Alerting
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Platform ResponseOps team (formerly the Cases and Alerting teams) t//
v7.9.0
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
closes #73245
Checklist
Delete any items that are not applicable to this PR.
For maintainers