Skip to content

Conversation

@gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Jul 28, 2020

Summary

This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.

closes #73245

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@gmmorris gmmorris added Feature:Alerting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.10.0 v7.9.0 v8.0.0 labels Jul 28, 2020
@gmmorris gmmorris self-assigned this Jul 28, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris gmmorris marked this pull request as ready for review July 28, 2020 13:58
@gmmorris gmmorris requested a review from a team as a code owner July 28, 2020 13:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@gmmorris gmmorris added the release_note:skip Skip the PR/issue when compiling release notes label Jul 28, 2020
@gmmorris gmmorris merged commit 5e8e01f into elastic:master Jul 28, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
# Conflicts:
#	x-pack/plugins/alerts/server/saved_objects/migrations.test.ts
#	x-pack/plugins/alerts/server/saved_objects/migrations.ts
#	x-pack/test/alerting_api_integration/spaces_only/tests/alerting/migrations.ts
gmmorris added a commit that referenced this pull request Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
gmmorris added a commit that referenced this pull request Jul 28, 2020
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
@mikecote mikecote mentioned this pull request Aug 5, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.9.0 v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading to 7.9-BC4 fails on migration of Index Threshold Alert

4 participants