[Ingest Manager] API sends 404 when package config id is missing #73212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2020 13:22
Currently failing with a 500 as in #66388
The test initally failed with a 500 when the `after` was added. Debugging narrowed it down to a missing default config. getDefaultAgentConfigId errors if there isn't a default config. The config is added by `setupIngestManager` which _was_ always called during plugin#start but is no longer. We could add the setup call to the test/suite, but instead I changed AgentConfigService.delete to use ensureDefaultAgentConfig instead of getDefaultAgentConfigId. ensureDefaultAgentConfig adds one if it's missing. The check in delete is to make sure we don't delete the default config. We can still do that and now we add a config if it wasn't already there (which seems like A Good Thing)
jfsiii
added
the
Team:Fleet
jfsiii
changed the title
Contributor
Author
|
cc @elastic/endpoint-app-team for the text change in https://github.com/elastic/kibana/pull/73212/files#diff-d892c26bb4fc08d103899f8234beb2d4 |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
nchaulet
approved these changes
Jul 25, 2020
jfsiii
commented
Jul 25, 2020
| import { TypeOf } from '@kbn/config-schema'; | ||
| import Boom from 'boom'; | ||
| import { RequestHandler } from 'src/core/server'; | ||
| import { RequestHandler, SavedObjectsErrorHelpers } from '../../../../../../src/core/server'; |
Contributor
Author
There was a problem hiding this comment.
I added the relative path here because I was getting an error like "cannot find module 'src/core/server'" when I added the helpers
jfsiii
added
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@jen-huang I figured this would be backported to 7.9 because it's a bug fix for #66388 |
jonathan-buttner
approved these changes
Jul 27, 2020
Contributor
Author
|
Spun the change in /agent_configs/delete behavior into separate PR #73376 if we'd rather deal with it separately |
Contributor
Author
We just got an email from @ph that only blockers should be backported to 7.9. This isn't a blocker. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
jfsiii
pushed a commit
that referenced
this pull request
Jul 29, 2020
) (#73659) * Add test to confirm missing config responds w/ 404 Currently failing with a 500 as in #66388 * Use after() to remove items added by test. The test initally failed with a 500 when the `after` was added. Debugging narrowed it down to a missing default config. getDefaultAgentConfigId errors if there isn't a default config. The config is added by `setupIngestManager` which _was_ always called during plugin#start but is no longer. We could add the setup call to the test/suite, but instead I changed AgentConfigService.delete to use ensureDefaultAgentConfig instead of getDefaultAgentConfigId. ensureDefaultAgentConfig adds one if it's missing. The check in delete is to make sure we don't delete the default config. We can still do that and now we add a config if it wasn't already there (which seems like A Good Thing) * Fix package config path in OpenApi spec * Return 404 if package config id is invalid/missing * Change test for error displayed text Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #66388
Respond with a 404 when a given package config id cannot be found
Added test to confirm 404
Changed
AgentConfigService.deleteto not throw if a default config isn't present. Behavior & reasoning described in b4f4051. I created a separate PR and added a test in [Ingest Manager] Fix /agent_config/delete API 500 if default config missing #73376 if we want to deal with it separately. I could also close that and bring the test over to this branch.Updated the expected text in an Endpoint UI test
Checklist
Delete any items that are not applicable to this PR.