-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Fix es_ui_shared eslint violations for useRequest hook #72947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cjcenizal
merged 26 commits into
elastic:master
from
cjcenizal:chore/use-request-eslint
Aug 31, 2020
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d996312
Remove index_management and snapshot_restore from eslintrc.
cjcenizal 21fb1e6
Reconcile request helpers with eslint rules for React hooks.
cjcenizal 5e29bf4
Replace original request.ts with np_ready_request.ts.
cjcenizal a813c3c
Remove cleanup function which introduced a bug by setting isMounted t…
cjcenizal 248608e
Bring back isOutdatedRequest to gracefully handle changing poll inter…
cjcenizal 7de3e5b
Fix useRequest and sendRequest tests. Split into two test files.
cjcenizal 82ba37c
Reorganize modules and convert tests to TS.
cjcenizal cb6a82d
Ignore eslint violation from isOutdatedRequest flag.
cjcenizal 2fe8e19
Remove unnecessary useMemo.
cjcenizal ea6d8e4
Merge branch 'master' into chore/use-request-eslint
cjcenizal ba508fe
Revert "Remove unnecessary useMemo."
cjcenizal 6492468
Add comment explaining purpose of stringifiedQuery.
cjcenizal ff5f88a
Clarify purpose of deserializer return value test.
cjcenizal b83fc41
Rename helpers files to test.helpers to clarify their role.
cjcenizal ded10ed
Remove outdated comments.
cjcenizal bb429c3
Convert useRequest to implement useCallback to define sendRequest bas…
cjcenizal c4ab04d
Merge branch 'master' into chore/use-request-eslint
cjcenizal 646b5fa
Merge branch 'master' into chore/use-request-eslint
cjcenizal a542b42
Convert everything to hooks, fix bug tracking outdated responses, and…
cjcenizal e5dc061
Merge branch 'master' into chore/use-request-eslint
cjcenizal 6ff6124
Remove unnecessary mention of isMounted from scheduling useEffect hook.
cjcenizal 40820aa
Skip lint rule for other modules.
cjcenizal 1df8e52
Merge branch 'master' into chore/use-request-eslint
elasticmachine fc2f91e
Clarify comments.
cjcenizal b3414b7
Apply Seb's comments re comments.
cjcenizal 0e99888
Fix Watcher memoization bugs.
cjcenizal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
184 changes: 0 additions & 184 deletions
184
src/plugins/es_ui_shared/public/request/np_ready_request.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for removing it here and adding the comments in the few places we still have the issue 👍