Skip to content

[Canvas] Provide service stubs #72708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 23, 2020
Merged

[Canvas] Provide service stubs #72708

merged 10 commits into from
Jul 23, 2020

Conversation

@clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Jul 21, 2020

Summary

Builds upon #72436
Depends on #72683 (code is included until merged)

This PR takes the work from #72436 and creates a set of usable stubs for Storybook, Shareable Runtime, or any other context where Kibana services are not present. It also allows for custom service implementations to be provided on an ad-hoc basis.

This also abstracts away our Kibana services dependencies into a thin layer, which makes both replacement and tracking of those dependencies easier.

NOTE: Canvas code should not be accessing Kibana services directly. Any accessor should be abstracted similarly to maintain this decoupling.

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.10.0 labels Jul 21, 2020
@clintandrewhall clintandrewhall requested review from a team as code owners July 21, 2020 18:32
@clintandrewhall
Copy link
Contributor Author

clintandrewhall commented Jul 22, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 23, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
canvas 1.5MB -4.6KB 1.5MB

page load bundle size

id value diff baseline
canvas 1.4MB +3.7KB 1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very clean!

@clintandrewhall clintandrewhall merged commit 75beedb into elastic:master Jul 23, 2020
@clintandrewhall clintandrewhall deleted the service-stubs branch July 23, 2020 21:10
@clintandrewhall clintandrewhall mentioned this pull request Jul 23, 2020
Merged
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jul 23, 2020
@clintandrewhall @elasticmachine
[Canvas] Provide service stubs (elastic#72708)
e85cd81 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
clintandrewhall added a commit that referenced this pull request Jul 23, 2020
@clintandrewhall @elasticmachine
[7.x] [Canvas] Provide service stubs (#72708) (#73143)
aea554a 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@clintandrewhall clintandrewhall mentioned this pull request Jul 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

+1 more reviewer

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clintandrewhall @kibanamachine @ryankeairns @poffdeluxe @elasticmachine