[Discover] Migrate last karma tests to jest #72649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
|
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
VladLasitsa
added
Feature:NP Migration
release_note:skip
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
alexwizp
reviewed
Jul 22, 2020
| return $(this).slice(index); | ||
| }); | ||
| angular.element.prototype.filter = jest.fn(function (condition) { | ||
| return $(this).filter(condition); |
Contributor
There was a problem hiding this comment.
oh... my eyes =) But I also don't know better solution to do it without loading jQuery for JEST
alexwizp
reviewed
Jul 22, 2020
| angular.mock.inject(function ($rootScope, Private, $timeout) { | ||
| $parentScope = $rootScope; | ||
| timeout = $timeout; | ||
| $parentScope.indexPattern = Private(FixturesStubbedLogstashIndexPatternProvider); |
Contributor
There was a problem hiding this comment.
Private(FixturesStubbedLogstashIndexPatternProvider) -> FixturesStubbedLogstashIndexPatternProvider()
kertal
approved these changes
Jul 23, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, thanks a lot, may the Karma you removed here add to your personal Karma 👍
just a suggestion concerning the PR title, commit, I'd suggest "[Discover] Migrate last karma tests to jest"
VladLasitsa
changed the title
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Jul 23, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 23, 2020
* master: (35 commits) Migrated karma tests to jest (elastic#72649) Migrate status page app to core (elastic#72017) Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834) Fix Firefox TSVB flaky test with switch index patterns (elastic#72882) [ML] Fixing link to index management from file data visualizer (elastic#72863) test: 💍 add test for sub-expression variables (elastic#71644) fix bug (elastic#72809) [keystore] use get_keystore in server cli (elastic#72954) Show step number instead of incomplete step. (elastic#72866) Fix bug where user can't add an exception when "close alert" is checked (elastic#72919) [Monitoring] Fix issues displaying alerts (elastic#72891) [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338) [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490) disable renovate masterIssue [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710) [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926) [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763) [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759) fix unexpected arguments to unload command Limits the upload size of lists to 9 meg size (elastic#72898) ...
VladLasitsa
added a commit
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated last discover karma tests to jest
Checklist
Delete any items that are not applicable to this PR.
For maintainers