[kbn/es-archiver] move to a package #72318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
spalger
force-pushed
the
implement/es-archiver-package
branch
from
42422fe to
6826eec
Compare
spalger
commented
Jul 17, 2020
| * under the License. | ||
| */ | ||
|
|
||
| export * from '../../../../src/legacy/utils/streams'; |
Contributor
Author
There was a problem hiding this comment.
This is temporary until I can move esArchiver off of node streams.
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Member
|
@elasticmachine merge upstream |
dmlemeshko
reviewed
Jul 20, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
dmlemeshko
approved these changes
Jul 21, 2020
Member
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Code LGTM. I successfully verified save, load and --help flag.
tylersmalley
approved these changes
Jul 22, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 22, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 22, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json
spalger
added a commit
that referenced
this pull request
Jul 22, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json
spalger
added a commit
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of moving the es-archiver to a more modern place I'd like to move the es_archiver logic to a package that is isolated from the rest of Kibana.
This PR uses the new
RunWithCommandshelper from@kbn/dev-utilsadded in #72311