Migrated fixed_scroll karma tests to jest #72258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
VladLasitsa
added
Feature:NP Migration
v7.9.0
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Jul 20, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, thank you so much for converting this 🙏 ! Run locally, works.
| beforeEach(function () { | ||
| spyJQueryScrollLeft = sandbox.spy($.fn, 'scrollLeft'); | ||
| spyJQLiteScrollLeft = sandbox.stub(); | ||
| angular.element.prototype.scrollLeft = spyJQLiteScrollLeft; |
Member
There was a problem hiding this comment.
you've cleaned up other angular.element.prototype props, so I think this should be cleanup up too
alexwizp
approved these changes
Jul 21, 2020
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Jul 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 21, 2020
* master: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)
VladLasitsa
added a commit
that referenced
this pull request
Jul 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
…feature-privileges * alerting/consumer-based-rbac: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) renamed variable to make it clear the SO client is unsecured Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) includes hidden params type in SO client Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)
Contributor
|
@VladLasitsa This PR was merged after the 7.10 FF, but only backported to 7.9 - this means these changes are in 7.9, but not in 7.x right now. Could you add a backport to 7.x as well? |
Contributor
|
or maybe @alexwizp can help with this |
Contributor
|
@VladLasitsa It should also be backported to 7.x |
alexwizp
pushed a commit
to VladLasitsa/kibana
that referenced
this pull request
Sep 7, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/discover/public/application/angular/doc_table/fixed_scroll.js
alexwizp
added a commit
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated fixed_scroll karma tests to jest
Checklist
Delete any items that are not applicable to this PR.
For maintainers