Skip to content

[Security Solution] Remove compressed prop for EuiBasicTable #72039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[Security Solution] Remove compressed prop for EuiBasicTable #72039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a3326
remove compressd for tables
angorayc Jul 16, 2020
f661a4d
update snapshot
angorayc Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion x-pack/plugins/security_solution/public/common/components/ml/tables/anomalies_host_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ const AnomaliesHostTableComponent: React.FC<AnomaliesHostTableProps> = ({
<BasicTable
// @ts-ignore the Columns<T, U> type is not as specific as EUI's...
columns={columns}
compressed
// @ts-ignore ...which leads to `networks` not "matching" the columns
items={hosts}
pagination={pagination}
Expand Down
1 change: 0 additions & 1 deletion .../plugins/security_solution/public/common/components/ml/tables/anomalies_network_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ const AnomaliesNetworkTableComponent: React.FC<AnomaliesNetworkTableProps> = ({
<BasicTable
// @ts-ignore the Columns<T, U> type is not as specific as EUI's...
columns={columns}
compressed
// @ts-ignore ...which leads to `networks` not "matching" the columns
items={networks}
pagination={pagination}
Expand Down
1 change: 0 additions & 1 deletion ...ion/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...k/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export const JobsTableComponent = ({ isLoading, jobs, onJobStateChange }: JobTab
return (
<EuiBasicTable
data-test-subj="jobs-table"
compressed={true}
columns={getJobsTableColumns(isLoading, onJobStateChange, basePath)}
items={getPaginatedItems(jobs, pageIndex, pageSize)}
loading={isLoading}
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/security_solution/public/common/components/paginated_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ const PaginatedTableComponent: FC<SiemTables> = ({
<>
<BasicTable
columns={columns}
compressed
items={pageOfItems}
onChange={onChange}
sorting={
Expand Down
1 change: 0 additions & 1 deletion ...ins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ export const TimelinesTable = React.memo<TimelinesTableProps>(
return (
<BasicTable
columns={columns}
compressed
data-test-subj="timelines-table"
isExpandable={true}
isSelectable={actionTimelineToShow.includes('selectable')}
Expand Down