Skip to content

[7.9] [APM] Add error rates to Service Map popovers (#69520) #71994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2020
Merged

[7.9] [APM] Add error rates to Service Map popovers (#69520) #71994

merged 2 commits into from
Jul 17, 2020

Conversation

@smith
Copy link
Contributor

@smith smith commented Jul 16, 2020

Backports the following commits to 7.9:

@smith @cauemarcondes
[APM] Add error rates to Service Map popovers (elastic#69520)
a0858f7 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes elastic#68160.

Co-authored-by: cauemarcondes <caue.marcondes@elastic.co>
@smith smith added the backport This PR is a backport of another PR label Jul 16, 2020
@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

retest

2 similar comments
@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

retest

@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

retest

@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

retest

3 similar comments
@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

retest

@smith
Copy link
Contributor Author

smith commented Jul 16, 2020

retest

@smith
Copy link
Contributor Author

smith commented Jul 17, 2020

retest

@smith
Copy link
Contributor Author

smith commented Jul 17, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 17, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 02b9ebc into elastic:7.9 Jul 17, 2020
@smith smith deleted the backport/7.9/pr-69520 branch July 17, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smith @kibanamachine @elasticmachine