Skip to content

[Uptime] Rename Whitelist to Allowlist in parse_filter_map #71584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020
Merged

[Uptime] Rename Whitelist to Allowlist in parse_filter_map #71584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d933c80
[Uptime] Rename Whitelist to Allowlist in parse_filter_map
andrewvc Jul 14, 2020
defe2e0
Merge branch 'master' into white-to-allow
elasticmachine Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/uptime/public/components/overview/filter_group/parse_filter_map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface FilterField {
* If your code needs to support custom fields, introduce a second parameter to
* `parseFiltersMap` to take a list of FilterField objects.
*/
const filterWhitelist: FilterField[] = [
const filterAllowList: FilterField[] = [
{ name: 'ports', fieldName: 'url.port' },
{ name: 'locations', fieldName: 'observer.geo.name' },
{ name: 'tags', fieldName: 'tags' },
Expand All @@ -28,7 +28,7 @@ export const parseFiltersMap = (filterMapString: string) => {
const filterSlices: { [key: string]: any } = {};
try {
const map = new Map<string, string[]>(JSON.parse(filterMapString));
filterWhitelist.forEach(({ name, fieldName }) => {
filterAllowList.forEach(({ name, fieldName }) => {
filterSlices[name] = map.get(fieldName) ?? [];
});
return filterSlices;
Expand Down