[ftr] don't require the --no-debug flag to disable debug logging #71535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jul 13, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 13, 2020
…stic#71535) Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 17, 2020
…stic#71535) Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience the dev-utils/run helper uses the flags
--silent,--quiet,--debug, and--verboseto indicate the log level that should be used for that script. In the functional test runner we wanted to default to adebuglogging level so we set the default for thedebugflag to true. This causes the lower logging levels to be ignored when determining the logging level to use as louder logging levels take precedence (the fact that we're using a default, and flag ordering are both not preserved).To fix this the dev-utils/run helper now accepts a
log.defaultLeveloption, which will be used when none of the logging related flags are passed, allowing the FTR to default todebuglevel and switch toquietas long as someone passes the--quietflag.