Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lodash package version #71392

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Jul 12, 2020

Overview:

  • lodash 4.17.15 -> 4.17.19

Needed to bump cypress because it included a transitive dependency of lodash that was pegged to 4.17.15.

#67961 previously updated cypress to 4.5.0 but was unable to use the latest at the time (4.7.0) because of a regression concerning authenticated URLs.
That regression was fixed in 4.8.0.

Update: I was mistaken, while the latest version of cypress (4.10.0) does include the fix for that regression, it's still pegged to the same version of lodash. The repo has a PR that merged to update lodash, but they haven't cut a new release of cypress yet. Instead, I left cypress as-is, added a yarn dependency resolution, and called it a day.

Needed to bump cypress because it included a transitive dependency
of lodash that was pegged to `4.7.15`.
@jportner jportner added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v6.8.12 labels Jul 12, 2020
@jportner jportner changed the title Bump cypress to 4.10.0 and lodash to 4.7.19 Bump cypress to 4.10.0 and lodash to 4.17.19 Jul 12, 2020
@jportner jportner changed the title Bump cypress to 4.10.0 and lodash to 4.17.19 Bump lodash package version Jul 12, 2020
@jportner
Copy link
Contributor Author

Flaky test looks unrelated, opening this up for review.

@jportner jportner marked this pull request as ready for review July 12, 2020 16:10
@jportner jportner requested a review from a team July 12, 2020 16:11
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jportner jportner merged commit 60032b8 into elastic:master Jul 13, 2020
jportner added a commit to jportner/kibana that referenced this pull request Jul 13, 2020
jportner added a commit to jportner/kibana that referenced this pull request Jul 13, 2020
# Conflicts:
#	package.json
#	yarn.lock
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 13, 2020
* master: (78 commits)
  Bump lodash package version (elastic#71392)
  refactor: 💡 use allow-list in AppArch codebase (elastic#71400)
  improve bugfix 7198 test stability (elastic#71250)
  [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198)
  [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172)
  [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269)
  [Security Solution] Allow to configure Event Renderers settings (elastic#69693)
  Fix a11y keyboard overlay (elastic#71214)
  [APM] UI text updates (elastic#71333)
  [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113)
  [SIEM] fix tooltip of notes (elastic#71342)
  address index templates feedback (elastic#71353)
  Upgrade EUI to v26.3.1 (elastic#70243)
  [build] Creates Linux aarch64 archive (elastic#69165)
  [SIEM][Detection Engine] Fixes skipped tests (elastic#71347)
  [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items
  [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911)
  [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886)
  [ML] DF Analytics:  stop status polling when job stopped (elastic#71159)
  [SIEM][CASE] IBM Resilient Connector (elastic#66385)
  ...
spalger added a commit that referenced this pull request Jul 13, 2020
@spalger
Copy link
Contributor

spalger commented Jul 13, 2020

Needed to revert this as it breaks the yarn cache, not sure the right course of action to correctly fix this, but ideally we can get it working in a way that doesn't cause additional errors to be logged by yarn and doesn't break the yarn cache.

@jportner
Copy link
Contributor Author

Needed to revert this as it breaks the yarn cache

Any idea what part of the yarn cache was breaking? Perhaps it's because I added the dependency resolution for cypress?
If that's the case, we could wait until the next Cypress version comes out (probably 4.11.0), then we won't need the dependency resolution at all.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Jul 14, 2020

My guess is that it's related the yarn warning about an ignored "invalid" lodash version in yarn.lock.

I have no idea what's causing the error, but I bet we've hit a yarn bug cause by the way resolutions are defined for several different lodash instances

@jportner
Copy link
Contributor Author

I figured out what broke the yarn caching (user error). Re-submitted this PR as #73122.

@jportner jportner deleted the bump-cypress-and-lodash-packages branch July 29, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants