-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Console] Fix example in help flyout #71188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Fix example in help flyout #71188
Conversation
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cjcenizal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, didn't test locally. WDYT of hardcoding the string in JS as a string literal to preserve whitespace? I think this would simplify things by removing the dependency on a webpack loader and removing a .txt file, which we don't use anywhere else AFAIK so it's a bit of an oddity. It would also prevent this bug from happening again.
jloleysens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alisonelizabeth Thanks for fixing this! I wonder when this happened and if it has to do with the use of import. In that case this may have been introduced after the NP migration.
I see that pre NP migration it was imported without !!raw-loader! (https://github.com/elastic/kibana/blob/6.5/src/core_plugins/console/public/src/directives/sense_help_example.js). Not that it matters too much :)
I tend to agree with CJ that we can probably just keep this in a const helpText =. But will leave it up to you!
|
@cjcenizal great suggestion! I updated the PR with this change. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
# Conflicts: # src/plugins/console/public/application/constants/help_example.txt
Fixes #69253
The example
.txtfile was imported incorrectly.Release note
This fixes an issue in Dev Tools Console where the example shown in the "Help" panel was formatted incorrectly.