Skip to content

Fix breadcrumb on panels for visibility / round corners #71010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Fix breadcrumb on panels for visibility / round corners #71010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7681d5
Fix breadcrumb on panels for visibility / round corners
Jul 7, 2020
848d1d1
remove duplicate
Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion x-pack/plugins/security_solution/public/resolver/view/assets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ type ResolverColorNames =
| 'graphControlsBackground'
| 'resolverBackground'
| 'resolverEdge'
| 'resolverEdgeText';
| 'resolverEdgeText'
| 'resolverBreadcrumbBackground';

type ColorMap = Record<ResolverColorNames, string>;
interface NodeStyleConfig {
Expand Down Expand Up @@ -438,6 +439,7 @@ export const useResolverTheme = (): {
processBackingFill: `${theme.euiColorPrimary}${getThemedOption('0F', '1F')}`, // Add opacity 0F = 6% , 1F = 12%
resolverBackground: theme.euiColorEmptyShade,
resolverEdge: getThemedOption(theme.euiColorLightestShade, theme.euiColorLightShade),
resolverBreadcrumbBackground: theme.euiColorLightestShade,
resolverEdgeText: getThemedOption(theme.euiColorDarkShade, theme.euiColorFullShade),
triggerBackingFill: `${theme.euiColorDanger}${getThemedOption('0F', '1F')}`,
};
Expand Down
9 changes: 7 additions & 2 deletions x-pack/plugins/security_solution/public/resolver/view/panels/panel_content_utilities.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ const ThemedBreadcrumbs = styled(EuiBreadcrumbs)<{ background: string; text: str
background-color: ${(props) => props.background};
color: ${(props) => props.text};
padding: 1em;
border-radius: 5px;
}

& .euiBreadcrumbSeparator {
background: ${(props) => props.text};
}
`;

Expand All @@ -46,11 +51,11 @@ export const StyledBreadcrumbs = memo(function StyledBreadcrumbs({
truncate?: boolean;
}) {
const {
colorMap: { resolverEdge, resolverEdgeText },
colorMap: { resolverBreadcrumbBackground, resolverEdgeText },
} = useResolverTheme();
return (
<ThemedBreadcrumbs
background={resolverEdge}
background={resolverBreadcrumbBackground}
text={resolverEdgeText}
breadcrumbs={breadcrumbs}
truncate={truncate}
Expand Down