[Ingest Manager] Show experimental packages by default #70997

jen-huang · 2020-07-07T18:16:55Z

Summary

Resolves #70026. Fixes #64981.

This PR enables experimental packages to be shown in Ingest Manager:

Adjusts the necessary typings to support registry /search endpoint spec done in Make release field available as part of /search endpoint package-registry#591
Adjusts /api/ingest_manager/epm/categories and /api/ingest_manager/epm/packages to pass through experimental: true param to corresponding registry endpoints
Always send experimental: true params on client-side to the Ingest Manager endpoints above ^
Adds badges and tooltips for Beta and Experimental packages to Integrations list and Integration detail pages

Also, some code clean up was done in Integrations section:

Removed unused component files
Restructured Integration details page code to use WithHeaderLayout to match rest of app
- This cleanup also makes loading of details page much nicer - layout doesn't jump around
Adjusted misc components to match closer to design (centered package cards, version next to Add integration button, etc)
Moved all styled components to outside of function components so that they are not created dynamically each time (there were many console warnings about this)

Testing

Until the changes in Make release field available as part of /search endpoint package-registry#591 are deployed, you will need a local registry build that contains these changes
- Without the above changes, you will not see Beta/Experimental badges on Integrations list page, but you will see the badge on Integration details page
- With the above changes, you will see Beta/Experimental badges on Integrations list and Integration detail page
- With or without the above changes, experimental packages will be shown everywhere

Screenshots

…up some epm components

…gories endpoint

…mental

elasticmachine · 2020-07-07T20:44:40Z

Pinging @elastic/ingest-management (Team:Ingest Management)

kibanamachine · 2020-07-07T22:15:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7a20d5e

Build metrics

✅ unchanged

History

💔 Build #59501 failed 696e76f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jfsiii

The design changes are product/design's (@mostlyjason & @hbharding) call but the code/UX improvements LGTM.

jfsiii · 2020-07-08T11:45:40Z

...lugins/ingest_manager/public/applications/ingest_manager/sections/epm/screens/home/index.tsx

@@ -61,7 +61,9 @@ export function EPMHomePage() {

 function InstalledPackages() {
  useBreadcrumbs('integrations_installed');
-  const { data: allPackages, isLoading: isLoadingPackages } = useGetPackages();
+  const { data: allPackages, isLoading: isLoadingPackages } = useGetPackages({
+    experimental: true,


Do we need this? Doesn't useGetPackages default to experimental: true?

If it's not doing anything different from the defaults, or the other calls without the argument, I'd like to remove it.

this param will be needed when we switch to having a toggle/option to turn on experimental packages (#64869) instead of showing by default because we should always show all installed packages regardless of release type. I'd like to keep this param here as it would be easy to overlook the necessary behavior here when we remove experimental: true from useGetPackages

jfsiii · 2020-07-08T11:48:50Z

x-pack/plugins/ingest_manager/server/services/epm/registry/index.ts

-  packageName: string,
-  internal: boolean = true
-): Promise<RegistrySearchResult> {
+export async function fetchFindLatestPackage(packageName: string): Promise<RegistrySearchResult> {


let's add a second param, options which takes internal: boolean = true and experimental: boolean = true.

That way we can still have this behavior if called with only the package name, but still allow other options if desired.

from what I saw in the code, the current usage of fetchFindLatestPackage implies finding the latest version given a package name regardless of if it's an internal package or experimental one. both internal and experimental always needs to be true to enable searching across all registry packages, so that's why I removed the existing internal param and didn't replace it with options

jfsiii · 2020-07-08T12:14:11Z

x-pack/plugins/ingest_manager/server/services/epm/registry/index.ts

+  const url = new URL(`${registryUrl}/categories`);
+  if (params) {
+    if (params.experimental) {
+      url.searchParams.set('experimental', params.experimental.toString());
+    }
+  }


We should be able to skip the individual tests by passing a record to URLSearchParams like

Suggested change

const url = new URL(`${registryUrl}/categories`);

if (params) {

if (params.experimental) {

url.searchParams.set('experimental', params.experimental.toString());

}

}

const url = new URL(`${registryUrl}/categories`);

if (params) {

url.search = new URLSearchParams(params)

}

If we only want some properties from params we can filter them

params.experimental comes in as a boolean. searchParams doesn't like that, hence the need for conversion to string with params.experimental.toString(). I think your suggestion would run into the same issue. this could be fixed by doing Object.entries(params).map() or similar to convert boolean values, but I'll defer this improvement for now as we're only dealing with one param here atm

* Add beta and experimental badges to epm list and detail pages; clean up some epm components * Clean up styled warnings * Fix types * Allow experimental query param to be passed through to registry /search * Allow experimental query param to be passed through to registry /categories endpoint * Fix buggy categories count (#64981) * Always enable experimental packages and categories * Handle long package names nicely; misc layout tweaks * Move experimental=true flag to client side * Prevent layout jumps even more * Adjust beta/experimental badge tooltip copy

jen-huang added 8 commits July 6, 2020 16:31

Add beta and experimental badges to epm list and detail pages; clean …

5764174

…up some epm components

Clean up styled warnings

c2c61d4

Fix types

f3e84e6

Allow experimental query param to be passed through to registry /search

e3dd212

Allow experimental query param to be passed through to registry /cate…

b0a9231

…gories endpoint

Fix buggy categories count (elastic#64981)

09cf991

Always enable experimental packages and categories

e91e997

Merge remote-tracking branch 'upstream/master' into ingest/epm-experi…

696e76f

…mental

jen-huang self-assigned this Jul 7, 2020

jen-huang added 4 commits July 7, 2020 12:28

Handle long package names nicely; misc layout tweaks

2818c40

Move experimental=true flag to client side

822114a

Prevent layout jumps even more

989be3f

Adjust beta/experimental badge tooltip copy

7a20d5e

jen-huang added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0 labels Jul 7, 2020

jen-huang marked this pull request as ready for review July 7, 2020 20:44

jen-huang requested a review from a team July 7, 2020 20:44

jen-huang changed the title ~~[WIP][Ingest Manager] Show experimental packages by default~~ [Ingest Manager] Show experimental packages by default Jul 7, 2020

jfsiii approved these changes Jul 8, 2020

View reviewed changes

jen-huang mentioned this pull request Jul 8, 2020

[Ingest Manager] Designs for enabling experimental packages #69740

Closed

jen-huang merged commit 90fb7a6 into elastic:master Jul 8, 2020

jen-huang deleted the ingest/epm-experimental branch July 8, 2020 18:06

jen-huang mentioned this pull request Jul 8, 2020

[7.x] [Ingest Manager] Show experimental packages by default (#70997) #71134

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ingest Manager] Show experimental packages by default #70997

[Ingest Manager] Show experimental packages by default #70997

jen-huang commented Jul 7, 2020 •

edited

Loading

elasticmachine commented Jul 7, 2020

kibanamachine commented Jul 7, 2020

jfsiii left a comment

jfsiii Jul 8, 2020

jen-huang Jul 8, 2020

jfsiii Jul 8, 2020

jen-huang Jul 8, 2020

jfsiii Jul 8, 2020

jen-huang Jul 8, 2020 •

edited

Loading

[Ingest Manager] Show experimental packages by default #70997

[Ingest Manager] Show experimental packages by default #70997

Conversation

jen-huang commented Jul 7, 2020 • edited Loading

Summary

Testing

Screenshots

elasticmachine commented Jul 7, 2020

kibanamachine commented Jul 7, 2020

💚 Build Succeeded

Build metrics

History

jfsiii left a comment

Choose a reason for hiding this comment

jfsiii Jul 8, 2020

Choose a reason for hiding this comment

jen-huang Jul 8, 2020

Choose a reason for hiding this comment

jfsiii Jul 8, 2020

Choose a reason for hiding this comment

jen-huang Jul 8, 2020

Choose a reason for hiding this comment

jfsiii Jul 8, 2020

Choose a reason for hiding this comment

jen-huang Jul 8, 2020 • edited Loading

Choose a reason for hiding this comment

jen-huang commented Jul 7, 2020 •

edited

Loading

jen-huang Jul 8, 2020 •

edited

Loading